[16.0] stock_picking_batch_creation: Allows to split picking #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new option 'Split picking exceeding the limits' on the wizard allow, when the system is not able to find a picking that fits the criteria to create the batch, to lower the criteria by removing those based on the volume, weight and number of lines. If a picking is found and you allow to split it, the system will try to split the picking so that the new picking fits the criteria and can be added to the batch.
lmignon
force-pushed
the
16.0-batch_creation_split_picking-lmi
branch
from
31a03d0 to
785b794
Compare
lmignon
force-pushed
the
16.0-batch_creation_split_picking-lmi
branch
from
785b794 to
c1d64ed
Compare
2 tasks
When we allow pickings to be split if one of the volume, weight or number of lines criteria exceeds the set limits, we take care to select the first picking to be processed in accordance with the processing order defined in the system.
jbaudoux
approved these changes
Dec 23, 2024
Comment on lines
+273
to
+281
| nbr_lines, volume, weight = self._get_picking_max_dimensions() | ||
| wizard = self.env["stock.split.picking"].with_context(active_ids=picking.ids) | ||
| wizard.create( | ||
| { | ||
| "mode": "dimensions", | ||
| "max_nbr_lines": nbr_lines, | ||
| "max_volume": volume, | ||
| "max_weight": weight, | ||
| } |
There was a problem hiding this comment.
Suggested change
| nbr_lines, volume, weight = self._get_picking_max_dimensions() | |
| wizard = self.env["stock.split.picking"].with_context(active_ids=picking.ids) | |
| wizard.create( | |
| { | |
| "mode": "dimensions", | |
| "max_nbr_lines": nbr_lines, | |
| "max_volume": volume, | |
| "max_weight": weight, | |
| } | |
| # In base split module | |
| def _prepare_prepare_split_picking_wizard(self): | |
| return { | |
| "mode": self.split_picking_exceeding_limits_mode | |
| } | |
| # In split_dimension module | |
| def _prepare_prepare_split_picking_wizard(self): | |
| res = super()._prepare_prepare_split_picking_wizard() | |
| if self.split_picking_exceeding_limits_mode == "dimensions": | |
| nbr_lines, volume, weight = self._get_picking_max_dimensions() | |
| res.update({ | |
| "mode": "dimensions", | |
| "max_nbr_lines": nbr_lines, | |
| "max_volume": volume, | |
| "max_weight": weight, | |
| }) | |
| return res | |
| # In base split module | |
| def _split_first_picking_for_limit(self, picking): | |
| wizard = self.env["stock.split.picking"].with_context(active_ids=picking.ids) | |
| wizard.create(self._prepare_split_picking_wizard()) |
Comment on lines
+290
to
+294
| nbr_lines, volume, weight = self._get_picking_max_dimensions() | ||
| return ( | ||
| picking.nbr_picking_lines > nbr_lines | ||
| or picking.volume > volume | ||
| or picking.weight > weight |
There was a problem hiding this comment.
Suggested change
| nbr_lines, volume, weight = self._get_picking_max_dimensions() | |
| return ( | |
| picking.nbr_picking_lines > nbr_lines | |
| or picking.volume > volume | |
| or picking.weight > weight | |
| # In base split module | |
| def _is_picking_exceeding_limits(self, picking): | |
| return False | |
| # In split_dimension module | |
| def _is_picking_exceeding_limits(self, picking): | |
| if self.split_picking_exceeding_limits_mode == "dimensions": | |
| nbr_lines, volume, weight = self._get_picking_max_dimensions() | |
| return ( | |
| picking.nbr_picking_lines > nbr_lines | |
| or picking.volume > volume | |
| or picking.weight > weight | |
| ) | |
| return super()._is_picking_exceeding_limits(picking) |
jbaudoux
requested changes
Dec 23, 2024
There was a problem hiding this comment.
Reviewing this again, I think we should split this into multiple modules.
The existing module should not depend on new modules (there are quite some modules to split by dimension).
I would move the split to a new module stock_picking_batch_creation_split defining split_picking_exceeding_limits and the mode split_picking_exceeding_limits_mode as a selection offering move and depending on stock_split_picking.
Edit: I think this move mode is useless. Maybe split_picking_exceeding_limits can be dropped and only the selection split_picking_exceeding_limits_mode kept with a default behavior as no split.
Then a module stock_picking_batch_creation_split_dimension that declares the mode by dimension and depends on stock_split_picking_dimension.
Then I can add a module stock_picking_batch_creation_split_bins that declares the mode by number of bins and would depend on stock_split_picking_nbr_bins.
jbaudoux
reviewed
Dec 23, 2024
Comment on lines
+317
to
+329
| # at this stage we have the first picking to add to the batch but it could | ||
| # exceed the limits of the available devices. In this case we split the | ||
| # picking and return the picking to add to the batch. The split is done only | ||
| # if the split_picking_exceeding_limits is set to True. | ||
| if ( | ||
| picking | ||
| and self.split_picking_exceeding_limits | ||
| and self._is_picking_exceeding_limits(picking) | ||
| ): | ||
| split_picking = self._split_first_picking_for_limit(picking) | ||
| if not split_picking and raise_if_not_found: | ||
| raise PickingSplitNotPossibleError(picking) | ||
| picking = split_picking |
There was a problem hiding this comment.
Move to stock_picking_batch_creation_split module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new option 'Split picking exceeding the limits' on the wizard allow, when the system is not able to find a picking that fits the criteria to create the batch, to lower the criteria by removing those based on the volume, weight and number of lines. If a picking is found and you allow to split it, the system will try to split the picking so that the new picking fits the criteria and can be added to the batch.
Depends on: